archetech / archon / 34003527198

87%

push

github

fix(keymaster): Make the HD-key cache and its identity one value (#1056)

* fix(keymaster): Make the HD-key cache and its identity one value

The cached HD key and the identity of the wallet it came from were two
fields, written separately. newWallet set the key before the passphrase
encryption it awaits and the identity after it, so an encryption running
in that window saw one wallet's identity paired with another wallet's key.
Such a pair passes the staleness check in getHDKeyFromCacheOrMnemonic, so
the wallet was written under a key its own seed does not derive and no
later read could open it. changePassphrase had the adjacent defect: it
attached the re-encrypted seed's identity to whichever key it found cached.

Hold both in one object instead. Half a pair is then never observable and
the ordering that caused this cannot be expressed, rather than being ruled
out by a comment that the next edit has to honour. The Python port carries
the same two-field shape -- correct today only because its passphrase
encryption happens to be synchronous -- so it moves to one value as well.

Closes #1052

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* test(keymaster): Point the uncovered-branch note at the renamed helper

The rationale for leaving hdkeyCacheId's undefined branch uncovered still
named the helper hdkeyCacheKey, which left it as the only occurrence of
that name in the repo.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

3923 of 4510 branches covered (86.98%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

8564 of 8992 relevant lines covered (95.24%)

721.9 hits per line