archetech / archon / 34040715412

87%

push

github

fix(cli): Exit non-zero when a command fails (#1062)

A handler that reported a failure returned a successful status in all three
CLIs, so `keymaster create-id alice && next` ran next after alice failed and
no script, Makefile or CI step could tell. The JS CLIs swallowed it in 145 and
146 catch blocks that printed and returned; the Python dispatcher caught the
exception, reported it, and returned 0 unconditionally.

Report through a fail() helper that also sets process.exitCode -- exitCode
rather than exit(1), so stdout a partially-completed command already wrote
still flushes. Python returns 1 instead, its dispatcher owning the status.

Both languages also had in-handler failures that printed and returned without
raising at all -- Credential not found, Send failed, No current ID set: 8 in
the package CLI, 6 in the container CLI, 13 in Python, where they now raise a
CommandError the dispatcher already knows how to report. Stderr is unchanged
throughout; only the status moves.

create-id's backup advice is the one message that is not a failure, and says
so by calling notice(), which lets the guard rule stay absolute: inside a
command handler, a bare console.error is the shape that loses the status.

Closes #1054


Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

3928 of 4518 branches covered (86.94%)

Branch coverage included in aggregate %.

8574 of 9000 relevant lines covered (95.27%)

721.21 hits per line