kostafey / ejc-sql / 34000840626

38%

push

github

Stop calling interactive-only commands from Lisp

`replace-regexp', `goto-line', `beginning-of-buffer' and `end-of-buffer'
are all declared `interactive-only': besides doing the work, they push the
mark, deactivate it, widen the buffer and report counts, which is noise
when they are called from a program.

Replace the buffer motion with plain `goto-char', and add `ejc-goto-line'
and `ejc-replace-regexp' as the non-interactive counterparts of the other
two.  `ejc-replace-regexp' keeps the parts `ejc-format-sql' relies on: the
end boundary is a marker, so it survives replacements that change the text
length, and point is left after the last replacement, which is where the
boundaries of the next pattern are computed from.

The buffer contents and the resulting point position are unchanged.  Two
side effects are gone, both of them unwanted:

- `ejc-format-sql', `ejc-dress-sql-at-point' and `ejc-show-last-result' no
  longer push entries onto the mark ring.  The region still gets
  deactivated after the command, since modifying the buffer sets
  `deactivate-mark' anyway.

- `ejc-dress-sql-at-point' no longer widens a narrowed buffer.  `goto-line'
  counts lines in the whole buffer, while the line numbers passed to it
  come from `line-number-at-pos', which counts within the accessible
  portion, so in a narrowed buffer it used to quote the wrong lines.

3 of 12 new or added lines in 2 files covered. (25.0%)

392 of 971 relevant lines covered (40.37%)

4.71 hits per line