kostafey / ejc-sql

41%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• async-connect
• classpath
• clojure_java.jdbc_0.7.6
• devel
• keywords
• master
• new-cache
• results-ring
• revert-74-fallback-to-default-babel
• test
• test-exp
• tests
• v0.1
• v0.2
• v0.3
• v0.3.1
• v0.3.2
• v0.3.3

Build # 33932449691

Build Type

push

github

Committed by kostafey

Commit Message

Fix line comment detection at the end of SQL and with CRLF

`comments-re` required a trailing bare `\n` after a `--` line comment, so
such a comment was not recognized when it ended the SQL expression or when
lines were terminated with `\r\n`. A comment-only statement then passed the
"contains comments only" filter in `eval-user-sql` and was sent to the
database as a separate query.

Make the trailing line break optional, accept `\r\n` and match the comment
body with an explicit `[^\r\n]*` instead of relying on `$` under `DOTALL`.
`MULTILINE` is not needed anymore, since no anchors are left.

Coverage Stats

383 of 945 relevant lines covered (40.53%)

4.85 hits per line