kostafey / ejc-sql / 33994706884

40%

Build Type

push

github

Committed by kostafey

Commit Message

Enable `lexical-binding' in the remaining files

Only `ejc-sql', `ejc-interaction' and `ejc-company' had the cookie, the
other ten files were still compiled with dynamic binding.  Add it
everywhere and fix what relied on the leaking bindings:

- `ejc--in-sql-boundaries' decided whether to restrict the boundaries by
  testing `(boundp 'beg)', that is, by whether the enclosing function
  happened to have `beg' and `end' parameters.  `ejc-get-sql-at-point' and
  `ejc-flash-this-sql' now pass their `:beg' and `:end' to
  `ejc-get-sql-boundaries-at-point' themselves, and
  `ejc-apply-in-sql-boundaries' takes the restrictions as arguments, so
  `ejc-format-sql' keeps narrowing the formatting to the region.  The macro
  is left for the unrestricted case only.

- `ejc-db' moves to `ejc-lib', which every module requires, and
  `ejc-result-table-impl' moves to `ejc-result-mode', where it is
  dispatched on.  Both were defined in `ejc-sql', which is loaded last, so
  every earlier module referenced them as free variables.

- Declare the variables of the optional `yasnippet', `flx' and `ido'
  packages, and the `ejc-sql-mode' flag, in the files that read them.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HReKpDmEf79JLWhV9mbvNi

Coverage Stats

7 of 8 new or added lines in 1 file covered. (87.5%)

262 existing lines in 10 files now uncovered.

392 of 964 relevant lines covered (40.66%)

4.75 hits per line