coreui / coreui-pro / 33904710910

94%

main: 94%

push

github

refactor(Sidebar): v6 rework (draft) (#1147)

* refactor(Sidebar): token maps, transition tokens, narrow partial owns its variables

Step 1 of the sidebar rework: structure only. Every --cui-sidebar-* token
now comes from a defaults() map ($sidebar-tokens, -toggler-, -overlaid-,
-backdrop-, -nav-, -nav-tree-, -narrow-, -narrow-unfoldable-tokens)
applied with tokens(), so the sidebar has the same Sass override point
as every other component. The six literal transitions are tokens; the
toggler's padding and radius are tokens instead of Sass values baked
into the rule; the narrow variant's variables move to its own partial;
the three occupy blocks share one mixin.

Two rendered changes, both deliberate: .sidebar-narrow read
--cui-sidebar-toggler-height for its padding-bottom while the token was
declared on the toggler, a descendant, so the padding silently fell to
0 — the token is declared on .sidebar now and the padding is back
(measured 0 -> 8 px). .nav-title and .nav-group set their own display
(block / flex column), so they stop being list-items under
list-style-type: '' — the Safari empty-marker case from #916.

Docs: the sidebar-nav and sidebar-narrow variable blocks are cited on
the page for the first time. sass-true 100/0, docs build green.

* feat(Sidebar): theme slots, scheme classes, hover and active on the foreground ladder

Step 2 of the sidebar rework. The sidebar reads the --cui-theme-* slots:
its own tokens carry --cui-theme-bg / --cui-theme-contrast inside the
value (declared and read on .sidebar), while the nav links, icons,
titles and group indicators read --cui-theme-contrast, --cui-theme-hover
and --cui-theme-active in the rule (their tokens live on .sidebar-nav),
so .sidebar.theme-<color> paints the whole column from that colour's
slots. .sidebar-light joins .sidebar-dark as the color-scheme switch.

Hover and active links move off the v5 reads: text from
--cui-emphasis-color to --cui-fg-body, background from the Sass-computed
--cui... (continued)

4833 of 5430 branches covered (89.01%)

Branch coverage included in aggregate %.

30 of 40 new or added lines in 1 file covered. (75.0%)

9261 of 9659 relevant lines covered (95.88%)

401.44 hits per line