hyperledger-labs / fabric-smart-client / 33858387024

86%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabricx): report the status of an already-final transaction (#1718)

On fabricx, AddFinalityListener for a transaction the committer had already
reported answered Unknown rather than that transaction's real status, breaking
the contract in platform/common/driver/committer.go ("or it is already valid or
invalid"). The committer's notification stream reports a transaction once, and
nothing in the finality path could answer for one it had already reported: the
query-service-backed vault already resolves transaction status, but was wired
only to VaultService.

ResolvingListenerManager now wraps the notification manager. It resolves status
first, subscribes only when the transaction is not yet final, and treats a later
Unknown from the notification path as a reason to ask again rather than as a
verdict. No polling and no cache, because the query service is authoritative at
every point.

integration/fabricx/iou now exercises UpdateIOU, which it never had -- the
visible symptom of this defect -- using approver1, since the iou namespace policy
names only Org1 and fabric-x checks it against the transaction's own signatures.
The defect also fired silently on every successful create, in ApproverView,
whose view nothing waits for.

The integration suites shared a finality listener that discarded any status but
the one it expected, turning a wrong answer into an unbounded wait, and that
slept inside OnStatus, which the same contract forbids. One context-aware
listener in integration/fabric/common/views replaces both copies and fails in
seconds naming both statuses; its call sites now also check the registration
error and remove their listeners. Removing that sleep shortened the IOU flow to
well inside Prometheus' 15s scrape interval, so CheckPrometheusMetrics polls
instead of sampling once.

Closes #1714

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

91 of 95 new or added lines in 2 files covered. (95.79%)

7 existing lines in 3 files now uncovered.

31251 of 36687 relevant lines covered (85.18%)

2689.83 hits per line