hyperledger-labs / fabric-smart-client / 33849632453

86%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(storage)!: replace squirrel with an internal SQL builder (#1711)

github.com/Masterminds/squirrel is unmaintained. Replace it with
internal/storage/sqlbuild, a minimal builder that renders statements
directly, and delete the in-house query package that wrapped it.

- add internal/storage/sqlbuild: statement builder, WHERE conditions
  (Eq/Gt/Gte/Lt/In/And) and pagination, numbering $N placeholders in
  write order so a placeholder and its argument cannot drift apart
- port every call site in the vault, key-value, identity and
  simple-key-data stores, pinning the exact SQL of each query with
  sqlmock oracles first so the port is provably byte-identical
- render pagination through sqlbuild and drop the squirrel renderers
- unify placeholders on $N for both sqlite and postgres, so nine
  exported constructors no longer take a sq.PlaceholderFormat
- with squirrel gone the driver/sql/query tree held only pagination and
  FieldName, so lift both out of it and delete the tree

BREAKING CHANGE: pagination.ApplyToSquirrel, the sqlite and postgres
NewConditionInterpreter/NewPaginationInterpreter, and the nine
constructors' ph sq.PlaceholderFormat parameter are removed.

BREAKING CHANGE: the storage/driver/sql/query tree is removed. Its
pagination package moves to platform/view/services/storage/driver/pagination
and its FieldName type moves into platform/view/services/storage/driver
(driver.FieldName).

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

306 of 316 new or added lines in 32 files covered. (96.84%)

20 existing lines in 9 files now uncovered.

31131 of 36593 relevant lines covered (85.07%)

3441.58 hits per line