polserver / polserver / 33838565166

82%

Build Type

push

github

Committed by web-flow

Commit Message

Fix Distance(), DistanceEuclidean() and GetRegionName() for objects that stand nowhere (#958)

uo::Distance() returned 65535 for the contents of a container opened with
uo::SendOpenSpecialContainer(), a bank box being the usual one. Such a container
stands nowhere, so Pos4d::pol_distance() refuses it on the realm comparison; it
only ever answered 0 because opening the box wrote the character's own position
onto it. Being shown a container is what puts its contents in reach now, the
same question Character::can_reach() asks and the one #952 taught Accessible().

uo::DistanceEuclidean() ignored realms entirely and subtracted the raw
coordinates of the two toplevel owners, so a bank box at the origin measured 141
from a character at (100,100), and identical coordinates in two realms came back
0. Both now resolve the same way: geometry when the two objects stand in the
same world, then 0 for a pair sharing a holder or for a container the character
was shown, then 65535. Geometry comes first because SendOpenSpecialContainer()
also takes a chest that really does stand in the world. An item on a cursor
keeps no coordinates while dragged, so it is measured from its holder.

uo::GetRegionName() crashed rather than answering wrongly: getregionid() reads
pos.realm() unchecked, and isa() is exact class equality, so a bank box or a
worn backpack -- both CLASS_CONTAINER -- never took the item branch. It resolves
through whatever holds the object now and errors for one standing in no realm.
The client's cached region is also only consulted when there is a client, an NPC
being logged_in() from creation with none.

Coverage Stats

39 of 41 new or added lines in 1 file covered. (95.12%)

1 existing line in 1 file now uncovered.

57403 of 72799 relevant lines covered (78.85%)

1286315.93 hits per line