polserver / polserver / 33966229915

82%

Build Type

push

github

Committed by web-flow

Commit Message

Clamp AOS tooltip text before narrowing it to 16 bits (#959)

utf16.size() was cast to u16 before the range check, so a text longer than 65535
characters wrapped to a small value, passed the check unresized, and tripped the
packet-size assertion in Write, which can shut the shard down. A script can set
a name or description of any length.

The old 0xFFFF / 2 - 22 was not a mis-parenthesised ( 0xFFFF - 22 ) / 2 - that
would overflow the packet, since the fixed overhead is 25 bytes, not 22: id 1,
length 2, unk1 2, serial 4, unk2/unk3 2, revision 4, cliloc 4, text length 2 and
the 4-byte terminator. ( 0xFFFF - 25 ) / 2 is 32755 characters, which fills the
packet to exactly 65535 bytes.


Claude-Session: https://claude.ai/code/session_01XWxMZWAVo2agN6axNF22o2

Co-authored-by: murderinc <3738856+murderinc@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

2 of 3 new or added lines in 1 file covered. (66.67%)

6 existing lines in 2 files now uncovered.

57402 of 72799 relevant lines covered (78.85%)

1287133.03 hits per line