polserver / polserver / 32658215540

82%

Build Type

push

github

Committed by web-flow

Commit Message

Fix Accessible() for the contents of a shown container (#952)

uo::Accessible() returned 0 for anything inside a container opened with
uo::SendOpenSpecialContainer(), a bank box being the usual one.

Such a container stands nowhere, so Character::can_access() refused it on the
realm comparison inside Pos4d::in_range() before any coordinate was looked at.
It only ever passed because opening the box used to write the character's own
coordinates onto it; that forging was removed, and every client-facing path
(lift, drop, double-click) was moved to Character::can_reach(), which grants
reach for a container the character was shown. can_access() was missed.

can_reach() falls through to the same in_range() for anything not shown, so
world, backpack and worn items are unaffected, and the find_legal_item() half
- which is what refuses the contents of a locked container - is untouched.

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

6 existing lines in 2 files now uncovered.

57373 of 72773 relevant lines covered (78.84%)

1289969.19 hits per line