coreui / coreui-pro / 33759812771

96%

main: 94%

push

github

fix(Stepper, RangeSlider, Avatar): stop painting graphics with the secondary surface (#1072)

* fix(Stepper): the upcoming step's number was invisible

`$stepper-step-indicator-color` read `--#{$prefix}secondary`, the role's base —
a surface colour. Against the page it measures **1.1:1**, so the number inside
an upcoming step could not be read at all. `--#{$prefix}fg-3` puts it at
5.29:1, and is the token the rest of the library reaches for at this level: the
step's own label is `fg-2`, and `fg-3` carries 36 other defaults.

The disabled variant read the same token and moves with it.

* fix(RangeSlider, Avatar): read a foreground, not the secondary surface

Both components painted a graphic with `--#{$prefix}secondary`, the theme
role's base — a surface colour that measures 1.1:1 against the page.

A disabled slider showed nothing: its filled portion and the empty track were
1.1:1 apart, and the thumb carries no border, so neither the value nor the
handle was visible. The fill reads `fg-4` now (2.4:1 against the track) and the
thumb `fg-3` (1.83:1 against the fill), which mirrors the enabled state, where
the thumb is the solid colour and the fill a tint of it.

An avatar status dot with no theme class was the same colour as the page behind
its white ring; `fg-4` puts it at 2.9:1.

Both also dropped a `color-mix()` that did nothing — one mixed the colour with
`transparent` at 100%, the other at 37.5% of a colour already indistinguishable
from white.

4830 of 5430 branches covered (88.95%)

Branch coverage included in aggregate %.

9263 of 9687 relevant lines covered (95.62%)

399.65 hits per line