ruby-grape / grape / 33728651997

97%

push

github

Look registrations up in a plain Hash instead of an indifferent one (#2891)

`Grape::Util::Registry` backs the format, parser, error-formatter, versioner,
validator and params-builder registries with a `HashWithIndifferentAccess`,
because registration and lookup disagree on spelling: `register` derives the
short name as a String (`klass.name.demodulize.underscore`), while the readers
arrive with a Symbol.

Three of those registries are read on the request path — `Grape::Formatter`
once per response, `Grape::Parser` once per parsed body,
`Grape::ParamsBuilder` once per params build — so `convert_key` ran on every
one of those lookups to answer a question that only ever had one answer.

Store both spellings instead, the same way `Grape::ContentTypes` does since
#2883:

    registry[short_name] = registry[short_name.to_sym] = klass

    HWIA[:json]     109.4 ns  ->  Hash[:json]     34.3 ns   3.19x
    HWIA['json']    117.7 ns  ->  Hash['json']    61.1 ns   1.93x

End to end, median of 5 interleaved runs against master (Ruby 4.0.5): **+2.8%**
on a minimal versioned GET, **+2.8%** with params and validations.

Nothing in the library removes a registration — only the suite does, through
the `Deregister` helper it mixes into `Grape::Util::Registry`. That helper now
deletes both spellings, which keeps undoing a registration where it is
actually needed instead of widening the public surface for it.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1238 of 1332 branches covered (92.94%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

3937 of 4005 relevant lines covered (98.3%)

27126.1 hits per line