hyperledger-labs / fabric-smart-client / 33638077282

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix(state): reject state:"hash" on fields that cannot be hashed (#1702)

Writing a state with state:"hash" on a field the tag handler could not
process failed in two ways, neither of them safely: a non-byte slice
panicked inside reflect.Value.Bytes, and any other unhandled kind fell
through the switch silently, so the value went to the ledger in the clear
while the caller believed it was hidden.

Both now return an error at write time. A field is hashable only if a
[]byte is assignable to it, which is the exact precondition for the two
reflect calls involved -- Bytes needs element kind uint8, Set needs
assignability, and only assignability implies both. Checking the element
kind instead would still admit []MyByte, which reads fine and then panics
in Set.

The read side is deliberately not a mirror. unmarshalTags runs on every
read path, so rejecting outright would make states already committed by a
release that skipped the kind silently unreadable, with no way to migrate
them. It therefore refuses only when a preimage is present, meaning the
field was hashed and cannot be verified; the write-side check stops new
occurrences. Slices are refused unconditionally, since those panicked
before anything was written and so cannot exist on a ledger.

Cover the error paths and boundary conditions of namespace.go, tags.go,
sbe.go and the trusted-read certifier, which the integration suites reach
only along their happy paths. Package coverage goes from 80.8% to 86.9%,
with namespace.go at 92.9%, sbe.go at 93.4% and tags.go at 94.2%.

Document the exported options in opts.go, and record as a TODO that
certified inputs and hash hiding do not currently compose: GetInputAt
serves a certified input without consulting the field mapping, so a
hash-hidden state read that way never recovers its preimage.

Closes #1701

Signed-off-by: Said Altury <Said.Altury@ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Co-authored-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

26 of 26 new or added lines in 2 files covered. (100.0%)

14 existing lines in 6 files now uncovered.

31224 of 36982 relevant lines covered (84.43%)

3423.84 hits per line