hyperledger-labs / fabric-smart-client / 33633328273

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix(collections): correct the iterator bugs the coverage tests pinned (#1700)

ReadFirst read one element past its limit and discarded that read's
error; ToMaxBy returned the zero value for an iterator whose keys all sit
below the key type's zero; CheckJaegerTraces let an empty span chunk
truncate the trace set, since FlattenValues cannot tell one from the end
of the stream.

The tests covering these cases asserted the broken behaviour, and two of
them could not fail at all: the Copy independence test built its readers
from separate sources, and the ReadFirst "stops early" test planted its
error exactly where the over-read discarded it. Both now discriminate.

Also bring the touched godoc in line with the FSC convention: state what
a caller must honour rather than how exhaustion is signalled internally,
record that Map and Flatten close their source, and move Map's
exhaustion-sentinel caveat out of a test comment onto the godoc.

Signed-off-by: Said Altury <Said.Altury@ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Co-authored-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

12 of 12 new or added lines in 2 files covered. (100.0%)

9 existing lines in 3 files now uncovered.

31105 of 36956 relevant lines covered (84.17%)

2828.11 hits per line