coreui / coreui-pro / 33621622545

93%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(Chip, ChipInput, Autocomplete, MultiSelect, Popup): release listeners and chip instances on dispose (#1050)

- Chip: the keydown and click listeners carry the component namespace, so
  BaseComponent.dispose() removes them
- ChipInput: the input-layer listeners carry the namespace and dispose()
  removes the text input's set, so typing after dispose does nothing
- Autocomplete: dispose() removes the listeners on the menu, the input, the
  cleaner, the indicator and the options list
- MultiSelect: dispose() and update() share one teardown that disposes the
  selection chips and their chip set, removes the chip listeners on the
  selection and the listeners of the replaced menu and wrapper
- Popup: hide() keeps the anchor keydown listener reference, so dispose()
  can remove it after any show/hide cycle

Coverage Stats

4772 of 5360 branches covered (89.03%)

Branch coverage included in aggregate %.

39 of 40 new or added lines in 4 files covered. (97.5%)

47 existing lines in 3 files now uncovered.

9100 of 9519 relevant lines covered (95.6%)

394.24 hits per line