FluentContracts / FluentContracts / 33487882822

99%

develop: 98%

push

github

Gate releases on a label, and stop a release that lost its version directive (#42)

* Hold releases back with a label rather than the commit subject

Releasing was gated on text in the merge commit subject. GitHub composes
that subject in the merge box when the page is rendered, so a tab opened
before the title was edited merges the subject it has been holding. That is
not hypothetical: the pull request before this one was titled with the
marker, merged without it, and started a release of a package identical to
the one already published. Only cancelling the run mid-build stopped it.

A label cannot go stale that way. It sits on the pull request, is visible
until the moment of merging, and is read at release time from the pull
request the merge commit came from.

- The pull request is resolved from the merge commit rather than by parsing
  "(#123)" out of the subject, since that is the same editable text the label
  exists to stop us depending on.
- The marker in a commit message is still honoured, for a direct push and so
  nothing already written down stops working.
- The answer is resolved once and cached: three targets ask, and it costs an
  API call.
- Releasing stays the default. A local build has no pull request to consult,
  and if the labels cannot be read the build says so plainly and releases,
  naming the commit-message marker as the way to hold one back regardless.

* Stop a release whose pull request asked for a bump the commit lost

GitVersion reads the bump directive out of the commit message, and GitHub
composes the squash commit subject from the pull request title when the
merge box is rendered. A title edited after that page was opened is not what
gets merged, so the directive can vanish between what was asked for and what
is built. That is how the previous merge lost its marker.

Losing it is worse for versioning than for the release gate: a lost major
ships breaking changes as a patch, straight into everyone's version range,
and c... (continued)

278 of 287 branches covered (96.86%)

Branch coverage included in aggregate %.

2138 of 2187 relevant lines covered (97.76%)

63.31 hits per line