FluentContracts / FluentContracts / 33506206170

99%

develop: 98%

push

github

Correct why a squash subject loses the version directive +semver: minor (#44)

The explanation written into the guidance and into the guard's own failure
message was wrong. It blamed a stale merge page: GitHub composing the subject
when that page is rendered, so a title edited afterwards is not what merges.
That fitted the first case only by coincidence, because that pull request had
also been retitled.

The real rule is the commit count. GitHub's squash default takes the merged
subject from the pull request title only when the branch has more than one
commit; with exactly one it uses that commit's own subject and never consults
the title. The correlation across the six merges so far is exact:

    #38  4 commits  +semver: minor in title   survived
    #39  2 commits  release marker in title   survived
    #40  3 commits  +semver: minor in title   survived
    #41  1 commit   release marker in title   lost
    #43  1 commit   +semver: minor in title   lost

So the directive was never dropped in transit. It was never in the merged
subject at all, because the title was not consulted.

The guard caught it on its first live run and stopped the release before
Pack, which is why 3.2.1 is not on nuget.org in place of 3.3.0.

This commit carries the directive in its own subject, which is what a
single-commit pull request needs until the repository setting for the squash
title is changed to always use the pull request title.

278 of 287 branches covered (96.86%)

Branch coverage included in aggregate %.

2145 of 2197 relevant lines covered (97.63%)

63.37 hits per line