FluentContracts / FluentContracts / 33395731517

99%

develop: 98%

push

github

Add five collection checks and fix NotContain accepting a partial match +semver: minor (#40)

* Add five collection checks and fix NotContain accepting a partial match

NotContain was the negation of Contain. Contain asks whether the collection
holds all of the given elements, so its negation passed whenever the
collection was missing any one of them: for [1, 2, 3], NotContain(2, 99)
passed even though the forbidden 2 was present, and the contract went
silently unenforced. It now fails if any of the elements is present.

- A single element was always correct and is unchanged, since that path
  short-circuits to Contains. Contain is untouched and still requires every
  element.
- NotContain() with no elements now passes rather than throwing, which
  matches Contain() being vacuously true on an empty set.
- CollectionContainmentTests pins down all three containment checks against
  the same partial overlap. Verified: three of its six tests fail without the
  fix.

New checks, added to CollectionContract so every collection contract gets
them rather than just lists:

- ContainAnyOf, the at-least-one-of counterpart to Contain's all-of and
  NotContain's none-of. Offered as (params T[]) plus (IEnumerable<T>, string?)
  so it cannot swallow a value as a message.
- HaveUniqueItems, NotContainNull.
- AllSatisfy and AnySatisfy, taking a predicate over the element type. On a
  dictionary that element is a KeyValuePair, which the dictionary tests cover.
  The empty collection is tested explicitly at both quantifiers, and a null
  predicate is rejected with ArgumentNullException naming it.

AGENTS.md now records the overload shape these checks follow, and why:
a message-first params overload binds wrongly when the element type is
string. EqualityContract.BeAnyOf still has that shape and is wrong for
StringContract, but correcting it changes the meaning of code that compiles
today, so it is left for the next major version.

757 tests pass, up from 742.

* Require ... (continued)

278 of 287 branches covered (96.86%)

Branch coverage included in aggregate %.

32 of 37 new or added lines in 2 files covered. (86.49%)

2138 of 2187 relevant lines covered (97.76%)

63.26 hits per line