pmd / pmd / 759

79%

push

github

[java] Fix #7009: ReplaceJavaUtilDate/Calendar miss pattern variables (#7010)

* [java] Fix #7009: ReplaceJavaUtilDate/Calendar miss pattern variables

Both rules matched only LocalVariableDeclaration, FormalParameter,
FieldDeclaration and ConstructorCall, so a variable introduced by a
pattern was never reported. Add TypePattern to both XPath expressions,
which covers instanceof patterns, switch case labels and the component
patterns of a record deconstruction.

* [java] Report record components in ReplaceJavaUtilDate/Calendar

Follow-up to the review on #7010.

Add RecordComponent to both XPath expressions, so a record component
declared as java.util.Date or java.util.Calendar is reported. Varargs
components parse as an array type and stay unreported, which matches
how Date[] parameters behave today.

Replace the java.sql.Timestamp test case with a fully qualified
java.util.Date one, so nothing added here depends on the java.sql
behaviour discussed in #6025.

Let the record deconstruction test declare record Box(Object value),
so it keeps covering only the nested type pattern now that the record
component itself is reported too.

19687 of 25790 branches covered (76.34%)

Branch coverage included in aggregate %.

42606 of 52657 relevant lines covered (80.91%)

0.82 hits per line