pmd / pmd / 757

79%

push

github

[java] Fix #5732: UnnecessaryCast false positive for package-private members (#6993)

* [java] Fix #5732: UnnecessaryCast false positive for package-private members

Package-private methods and fields are not inherited by subclasses in another package, so a cast to the declaring type is required to access them.

* [java] Fix #5732: Clarify package-private visibility in UnnecessaryCast

Package-private members are inherited; the cast is required because they
are not accessible on a subtype in a different package. Also drop
redundant unresolved/null checks already handled in visit().

* Put the issue title in release notes

---------

Co-authored-by: Sören Glimm <git@uncleowen.de>

19688 of 25790 branches covered (76.34%)

Branch coverage included in aggregate %.

19 of 22 new or added lines in 1 file covered. (86.36%)

42606 of 52657 relevant lines covered (80.91%)

0.82 hits per line