archetech / archon / 33464656975

87%

push

github

fix(cli): Stop printing Lightning keys to stdout (#998)

* fix(cli): Stop printing Lightning keys to stdout

add-lightning dumped the whole config, so `adminKey` and `invoiceKey`
landed in terminal scrollback, `script`/`tee` captures and CI logs, with
nothing saying which of the three values were secret or what to do with
them.

The keys are already persisted: addLightning writes them into the wallet
under the id's `lightning` entry before returning. Printing them gained
nothing and put the credentials in more places.

What each one is, from how they are used rather than by convention:
adminKey is passed to payLightningInvoice, zapLightning and
getLightningPayments -- it spends. invoiceKey is passed to
getLightningBalance, createLightningInvoice and checkLightningPayment,
and publish-lightning registers it on Drawbridge, so it is receive-only
and shared deliberately.

The command now reports the wallet id, says the keys are stored and that
the admin key can spend, and points at show-wallet, which does expose all
three -- checked rather than assumed.

Changed in all three CLIs, which all printed the raw object: the package
CLI, scripts/archon-cli.js and the Python CLI. No new command or option,
so the three-way CLI parity surface is untouched.

Closes #978

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* docs: State what the Lightning keys are, not why the output changed

The comment justified removing the old output -- "printing them only
copies credentials into scrollback" -- which describes an edit rather
than the code. It also named only two of the three commands that pass
adminKey, and called invoiceKey receive-only when it also reads balance
and payment status.

Now states what each key authorises, checked against the call sites:
adminKey is passed by lightning-pay, lightning-zap and
lightning-payments; invoiceKey creates invoices and reads balance and
payment status... (continued)

3881 of 4464 branches covered (86.94%)

Branch coverage included in aggregate %.

8528 of 8953 relevant lines covered (95.25%)

717.56 hits per line