archetech / archon / 33455065226

87%

push

github

fix(herald): Give /id pages real metadata for link previews (#997)

* fix(herald): Give /id pages real metadata for link previews

The identity page is what someone shares to introduce themselves, and
unfurlers do not run JavaScript, so every identity link arrived in Slack,
iMessage, Signal, Discord and nostr clients as an empty div under one
generic title. Search crawlers saw the same.

serve-static.mjs now also exports createStaticHandler({ root,
transformHtml }), keeping its CLI unchanged, so a wrapper can serve the
same files while rewriting the shell. serve-herald.mjs is that wrapper:
for /id/<name> it replaces the build's placeholder title and injects
description, Open Graph and Twitter tags built from the name and the
deployment's domain.

The route pattern matches the server's own rule from routes.ts
validateName -- lowercase letters, digits, hyphen, underscore, 3-32
characters -- so anything that could not be a registered name gets the
shell untouched rather than a card advertising an identity that does not
exist.

No lookup and no new network dependency: the name is in the path and the
domain is configuration, so the page describes itself without the client
image having to reach the API.

Closes #975

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* style: Reindent serve-static.mjs after the factory refactor

Wrapping the handler in createStaticHandler left its body at the original
indentation, which the lint step rejects. eslint --fix, no behavioural
change: the 27 static-server tests pass unchanged.

I linted the new test file and not the scripts I had restructured, so CI
found this rather than I did.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* fix(herald): Point og:url at the client origin, not Drawbridge

Review caught the compose wiring deriving the public URL from
ARCHON_D... (continued)

3881 of 4464 branches covered (86.94%)

Branch coverage included in aggregate %.

8528 of 8953 relevant lines covered (95.25%)

717.56 hits per line