archetech / archon / 33446311227

95%

push

github

perf(docker): Split cli and explorer into build and runtime stages (#996)

* perf(docker): Split cli and explorer into build and runtime stages

The last two images in #987, neither of which fitted the template used
for the rest.

cli is exec'd into rather than run, so what may be pruned is a question
about what the image is for. It carries the compiled workspaces, the
dependencies they resolve through, and scripts/ -- and nothing that only
the build needed. 1.09GB -> 621MB. Verified by using it: `keymaster
--version` reports 0.6.3, `--help` renders, and `create-wallet` loads
cipher and node:sqlite and reaches the gatekeeper connection.

explorer serves its bundle through its own server.js, which imports only
express and dotenv -- both resolving from the service's own
node_modules. The root tree is therefore not copied into the runtime at
all, which is why this is the largest reduction of the set: 1.27GB ->
288MB.

Checked against the previous image rather than assumed: both serve
`<title>Archon Explorer</title>` at /explorer/index.html, both return the
same status on /, /explorer, /explorer/ and /explorer/index.html, and the
same hashed asset resolves in both. The 302 on /explorer/ is present in
the old image too and is unrelated to this change.

Refs #987

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* fix(docker): Carry VITE_EXPLORER_BASE into the explorer runtime

Review caught the runtime stage losing it. server.js reads
VITE_EXPLORER_BASE to decide the path it serves under, and the bundle is
built against the same value, so an image built with a non-default base
served its assets from one path while the bundle referenced another.

Narrower than it appears: docker/compose/explorer.yml supplies the value
both as a build arg and in the environment, so compose deployments were
unaffected. The image alone was inconsistent.

Verified by building with --build-arg VITE_EXP... (continued)

3880 of 4464 branches covered (86.92%)

Branch coverage included in aggregate %.

8528 of 8953 relevant lines covered (95.25%)

717.56 hits per line