PHPOffice / PHPPresentation / 33431763213

94%

push

github

ODPresentation Writer : Write the pattern a pattern fill names, as the hatch OpenDocument has (#957)

* ODPresentation Writer : Write the pattern a pattern fill names, as the hatch OpenDocument has

A pattern fill fell through the switch in `writeStyleGraphic()` into `default:` and was written as
`draw:fill="none"`. The shape came out of the ODPresentation Writer empty, whatever pattern it had
been given, and a table cell with one came out with no fill written at all.

OpenDocument has no preset patterns. It has `draw:hatch`, which is one, two or three families of
parallel lines and nothing else, so thirty-two of the fifty-four map onto it: the horizontals, the
verticals, the diagonals, the dashes, the crosses, the grids, the checks, the trellis, the weave
and the plaid, each with the style, the angle and the spacing that draw it. The lines take the
start colour and the ground behind them takes the end colour -- `draw:fill-hatch-solid` is what
says the ground is painted at all, and without it the hatch is drawn over whatever is behind the
shape.

The other twenty-two are not lines: the bricks, the confetti, the three diamonds, the sphere, the
divot, the shingle and the twelve percentage screens. ODF cannot say them, and they are painted
solid in the colour of the pattern rather than dropped -- a shape filled with the wrong texture is
nearer what was asked for than an empty one.

* Changelog for #957

37 of 37 new or added lines in 3 files covered. (100.0%)

10834 of 11536 relevant lines covered (93.91%)

68.19 hits per line