PHPOffice / PHPPresentation / 33604005771

94%

push

github

PowerPoint2007 Reader : Read back the alpha a colour was written with (#961)

`loadStyleColor()` did the arithmetic itself and got it wrong twice. The
`(int)` cast bound to the division rather than the product, so 0.84
became 0 and every alpha but `FF` was read back as none at all; and
`dechex(0)` is one character, so the ARGB came out seven characters long
and the colour lost its first digit to the alpha.

`Color::setAlpha()` already rounds and pads correctly, so the reader
hands it the percent and lets it do the work. It wrote the hex pair in
lower case in front of a colour written in upper case everywhere else,
including the `COLOR_*` constants, so it upper-cases it now.

Every colour in this reader goes through here -- solid, gradient and
pattern fills, outlines, the fill of a chart serie and of its data
points.

Fixes #960

2 of 2 new or added lines in 2 files covered. (100.0%)

10836 of 11535 relevant lines covered (93.94%)

68.92 hits per line