PHPOffice / PHPPresentation / 33426243922

94%

push

github

PowerPoint2007 Writer and Reader : Write the pattern a pattern fill names, and read it back (#952)

* PowerPoint2007 Writer and Reader : Write the pattern a pattern fill names, and read it back

`a:pattFill` names its pattern with `prst`, and the Writer never wrote the attribute. The
element that came out carried two colours and no pattern -- valid, because the schema has
`prst` optional, so nothing ever said the pattern had gone missing. Every pattern fill this
library has written since patterns were added came out as a plain two-colour nothing.

The seventeen `FILL_PATTERN_*` constants could not have written a pattern either: their
values were the `ST_PatternType` of SpreadsheetML (`darkDown`, `lightGrid`, `mediumGray`),
inherited from PHPExcel, and that vocabulary shares not one value with the
`ST_PresetPatternVal` a presentation names a pattern by. All seventeen were invalid there.

`Fill` now carries the 54 presets the format defines, named after the value they write, and
keeps the seventeen old names as deprecated aliases of the preset each was asking for.
`Fill::PATTERN_TYPES` lists them, which is how the Writer tells a pattern fill from a fill
type that is none of the kinds it knows: a type outside the list is written as it was
before, without an attribute the schema would refuse.

The Reader had no branch for `a:pattFill` at all, so a pattern fill was read as no fill. It
reads one now, with its foreground and background colours, and goes on ignoring an element
that names no preset -- there is no fill type to read that back as.

* Changelog for #952

14 of 14 new or added lines in 2 files covered. (100.0%)

10808 of 11510 relevant lines covered (93.9%)

68.13 hits per line