PHPOffice / PHPPresentation / 33425135357

94%

push

github

PowerPoint2007 Reader : Read the eight kinds of chart it could not, and the data a series holds (#955)

* PowerPoint2007 Reader : Read the eight kinds of chart it could not, and the data a series holds

The Reader recognised one plot element, `c:barChart`. The Writer writes nine. A deck holding an
area, a bar in three dimensions, a doughnut, a line, a pie, a pie in three dimensions, a radar or
a scatter chart came back with a plot area that had been given no type, and the next thing to
touch it threw `UndefinedChartTypeException`. A file this library had just written could not be
read back.

`c:plotArea` holds exactly one of those elements, and the name of it is the whole of what says
which chart this is: the series, the categories and the labels underneath are the same either way.
So the type is now looked up by element name, the settings that belong to a kind of chart are read
by what that kind can be told -- the direction and the grouping of a bar, the hole and the first
slice of a doughnut, the explosion of a pie, the smoothing of a line -- and the `c:ser` loop, which
never had anything to do with the kind of chart it sat in, is read once for all nine.

The series came back empty even for the bar chart that was read. The Reader looked for
`c:strRef/c:strCache` and `c:numRef/c:numCache`, which is how a chart that points at a worksheet
keeps a copy of what it last read there. This library writes charts without a worksheet, and those
hold their points themselves, in `c:strLit` and `c:numLit`; the title is a bare `c:tx/c:v` rather
than a cell reference. Both forms are read now, and so are the `c:xVal` and `c:yVal` a scatter
chart calls its two axes.

`CouplingBetweenObjects` goes to 47: the nine kinds of chart are nine classes.

* Changelog for #955

* Restore the blank line between loadSeries() and what follows it

82 of 87 new or added lines in 1 file covered. (94.25%)

10793 of 11496 relevant lines covered (93.88%)

67.62 hits per line