bleedingdeacons / monitor / 33418041651
93%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 16
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.422% (+0.05%) from 92.368%
33418041651

push

github

web-flow 
fix(alerts): do not offer Reply on a notice (#39)

The Reply button appeared on every card, including acknowledgement
notices - which the server refuses outright, because a reply to a notice
would turn one answered call into an unbounded exchange between two
handsets. So the button looked like it worked, took a responder's words,
and lost them against a 404.

HandAlert gains IsNotice and CanReply, mirroring Alert::isNotice() on the
server, which stays the authority. The card binds the button's visibility
to it and AlertsViewModel checks it again before prompting - the hidden
button is a rendering decision, the guard is the rule.

Notices are recorded in the history too, so the same applied there.
AlertHistoryEntry now stores the kind and folds the notice check into
CanReply. Empty on rows written before this shipped, which reads as "not
a notice" and so keeps the behaviour those rows already had.

The history row also gains ShowReply, being open and repliable together,
because that button was IsVisible on one and IsEnabled on the other -
which left a permanently greyed button on notices. A property rather than
two bindings and a converter: the one that would have been needed does
not exist in the toolkit, and the last invented converter compiled
cleanly and then took the page down at runtime.

None of this narrows what can be replied to. The alert a notice reports
on is still repliable after somebody else has answered it, from its own
row in the history - which is the whole point of reply living there.

Verified on an SM-S926B against the test bed with both cards on screen at
once: the notice offers Close alone, the alert beneath it offers
Acknowledge and Reply.

1305 of 1412 relevant lines covered (92.42%)

1338.14 hits per line

Coverage Regressions

Lines Coverage ∆ File
11
80.36
2.81% Models/AlertHistoryEntry.cs
Jobs
ID Job ID Ran Files Coverage
1 33418041651.1 16
92.42
GitHub Action Run
Source Files on build 33418041651