blevesearch / bleve / 33380825071

52%

master: 52%

Build Type

Pull #2394

github

Committed by Samsonnyyeet

Commit Message

MB-73497: fix nil pointer panic in term searcher cleanup

newTermSearcherFromReader returns (*TermSearcher, error), and its callers
return that as a search.Searcher. On error the nil *TermSearcher became a
non-nil interface, so the `if searcher != nil` cleanup guards let it through
and (*TermSearcher).Close panicked on a nil receiver instead of the error
surfacing -- hit when a wide multi-term query trips the leaf term searcher
cap from MB-72535.

Check the return value at all three call sites, and add regression tests that
force the failure via MaxTermSearchersKey.

Pull Request Pull Request #2394: MB-73497: fix nil pointer panic in term searcher cleanup

Coverage Stats

8 of 15 new or added lines in 2 files covered. (53.33%)

10 existing lines in 2 files now uncovered.

20153 of 38972 relevant lines covered (51.71%)

0.58 hits per line