blevesearch / bleve

52%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• BQMain
• HEAD
• MB-65018
• MB-71114-knn-doc-score-explanation-fix
• MB-71967-search-field-override-fix
• MB-71968
• MB-72535
• MB-73497
• ajroetker/add-dynamic-index-templates
• ajroetker/add-more-complex-aggregation-support
• ajroetker/add-result-deduplication-aka-collapsing
• alice
• backport_MB-37392
• backport_json_tags
• backport_merger_fix
• backport_polygon1
• backport_polygon_changes
• batchFlush
• bitpack-simd
• blas
• bolt
• boltLeak
• bugFix
• cacheRootCount
• close_err
• commitProtocol
• compaction_bytes_stats
• conditional_snappy
• config_fix
• cosineFix
• coveralls
• cq
• ctl-timeout-test
• custom-query-error-propagation
• custom_expl
• cut_snappy_calls
• defensiveChecks
• dependabot/go_modules/golang.org/x/net-0.55.0
• deps
• dev
• doc-260
• docnum_missing_fix
• docs
• drop
• encryptTrainedIndex
• error_fuzzy
• faissUP
• fallbackPath
• fastbivf
• fastmerge
• fileCallbacks
• fileTransfer
• filterFix
• firestorm
• fix-2362-bare-slash-query
• fix/index-meta-empty-callback-id-trailer
• fixes
• fmdoc
• funcFix
• geo
• geoPerf
• geopoint_docvalues
• gha-hygiene
• goModUp
• gofmt
• govariant_removal
• gpu
• gpu-logging
• gpu-stats
• gpuDoc
• indexAPI
• indexExhaust
• knnDup
• loadchunk_minor
• mad-hatter-release
• master
• master-geopoint
• max_segment_size
• mb70770
• mergePlan
• metareader
• minor_docvalue_space_savings
• minor_fixes
• mod
• multisearch-fix
• nested
• nestedDocSize
• new_lev
• newlev_adoption
• nullIssue
• numsnapshots_config
• open_fix
• parMerge
• perf
• perf-fuzzy-regexp-opts
• perf-gar-v17-collector
• perf-standalone-opts
• perfGar1
• persister_fix
• pre-bbolt-bugfix
• repos
• rollback
• scorch
• scorchStatsFix
• shapeIndex
• simplifyFilter
• single-disjunction-min
• snap
• stats
• temp
• tfr_advance
• trainingParams
• travis_failure_fix
• unit-tests
• update
• upgrade
• v0.1.0
• v0.2.0
• v0.3.0
• v0.4.0
• v0.5.0
• v0.6.0
• v0.7.0
• v0.8.0
• v0.8.1
• v0.8.2
• v0.9.0
• v1.0.5
• vectorsmd
• vellum_for_fuzzy_regex
• vellum_sha
• vendot
• verUp
• vet_fixes
• vulcan
• zapConfig
• zapUP
• zapUp
• zap_version

Build # 35708798869

Build Type

push

github

Committed by web-flow

Commit Message

MB-73970: Skip writing fileWriter trailer to index metadata when unset (#2400)

Save() and UpdateWriter() unconditionally appended the file callback id
plus its 4-byte length to index_meta.json, even when no callback was
registered - in that case Id() is "" and the append still writes a
4-byte zero-length trailer after the JSON body.

That trailer breaks any older bleve reader that predates this callback
mechanism: openIndexMeta() there does a single strict json.Unmarshal
with no fallback, so trailing bytes after the closing '}' make it fail
with ErrorIndexMetaCorrupt - even though the index itself is fine and
never used a callback. This surfaced as a hard failure when a pindex's
on-disk files were copied (e.g. via cbgt's file-transfer-based
rebalance) from a node running this bleve version to a node running an
older one.

Only emit the trailer when fileWriter.Id() is non-empty, i.e. when a
callback is actually in use, keeping the no-callback case byte-for-byte
identical to the pre-existing index_meta.json format.

Coverage Stats

1 of 18 new or added lines in 1 file covered. (5.56%)

16 existing lines in 3 files now uncovered.

20145 of 38974 relevant lines covered (51.69%)

0.58 hits per line