coreui / coreui-pro / 33338941007

95%

main: 94%

push

github

fix(Sidebar): restore the toggler's focus indicator (#997)

The toggler set outline: 0 and replaced it with
box-shadow: var(--cui-sidebar-toggler-focus-shadow), whose value was the
--cui-focus-ring shorthand: <width> solid <color>. box-shadow does not
accept the solid keyword, so the declaration was invalid and dropped —
measured in Chromium, the focused toggler computed box-shadow: none with
outline-style: none, leaving keyboard users with no indicator at all.

It draws the ring with the shared focus-ring() mixin now, like the other
25 places in the stylesheet. The close button had already moved; the
sidebar was the last consumer of the box-shadow mechanism, which is why
--cui-sidebar-toggler-focus-shadow was the only *-focus-shadow token
left in the library. Both it and $sidebar-toggler-focus-shadow are gone.

The migration guide named $btn-close-focus-shadow and
$sidebar-toggler-focus-shadow as taking the token instead; neither
variable exists any more, so that sentence is corrected and the removed
token documented.

4750 of 5351 branches covered (88.77%)

Branch coverage included in aggregate %.

9050 of 9474 relevant lines covered (95.52%)

389.25 hits per line