Rotorsoft / act-root / 33274414677

100%

push

github

fix(act): keep static reaction targets out of the subscribed LRU (ACT-1582) (#1588)

* fix(act): keep static reaction targets out of the subscribed LRU

A static target is recorded at a +Infinity priority floor so the dynamic
resolver path can never re-open what the build-time subscribe owns. That
record lived in the `maxSubscribedStreams` LRU, so a churn of dynamic
targets could evict it — and the next dynamic resolution to that target
found no record, read that as never-seen, and re-subscribed the stream
with its own priority and lane.

The consequence is not cosmetic. A target declared `.to({lane: "slow"})`
flips to "default", and a worker sharded with `onlyLanes: ["slow"]` stops
claiming the stream it was provisioned for. It is silent, and it persists
until a restart re-subscribes the statics.

Static targets now live in their own map, never evicted. They are the
build-time `_static_targets` list, so the map is already bounded by the
registry and costs nothing it does not already hold — which makes the
floor an invariant by construction rather than a race against eviction,
and leaves no path to warn about. Only dynamically resolved targets, the
unbounded set the cap exists for, stay in the LRU.

`forget_subscribed` loses its statics filter: it walks the LRU, which no
longer holds any.

Closes #1582

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(act): name the two subscription maps as a pair

_static_subscriptions arrived beside a map still called _subscribed, which
left the distinction carried by one name and implied by the other. Renames
the LRU to _dynamic_subscriptions so the pair reads as the split it is, and
says in each comment which half it holds.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K5eB6CMELZJfayCYpQta8N

---------

Co-authored-by: rotorsoft <rotorsoft@outlook.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

4294 of 4294 branches covered (100.0%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

9274 of 9274 relevant lines covered (100.0%)

1171.85 hits per line