ruby-grape / grape / 33251982774

97%

master: 97%

Pull #2867

github

Extract the shared body of `requires` and `optional`

With the group-type check unified (#2864), requiredness passed as an
argument (#2865) and `as` taken as a keyword (#2866), the two methods differ
only in the name they redispatch a legacy Hash under and in whether what
they declare is required. Everything else — the group merge, the `using:`
handover, the attribute validation, the choice between a nested scope and a
leaf declaration — was written twice.

Move it into one private `declare`, leaving each DSL method a single
dispatch. `optional: !required` on the nested scope is only correct now that
`new_scope` no longer keys its type check off that flag.

The two `using:` helpers stay separate. They are not one computation with a
flag flipped: `requires` treats `except` as "these go in the other bucket",
while `optional` has no other bucket, so `:all` ignores `except` and `:none`
uses it to drop fields entirely.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1232 of 1324 branches covered (93.05%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 2 files covered. (100.0%)

3882 of 3950 relevant lines covered (98.28%)

27188.54 hits per line