ruby-grape / grape / 33251904324

97%

master: 97%

Pull #2866

github

Take `as` as a keyword argument in `requires` and `optional`

`as` renames a parameter, which is a DSL concern: the rename is performed
by `push_declared_params` and `new_scope`, and both already take it as a
keyword. It only travelled inside the options Hash so that those two calls
could read it back out as `opts[:as]`.

Nothing in the validation pipeline consumes it. `ValidationsSpec` does not
list `:as` among its spec-consumed keys, so the key falls through to
validator dispatch and instantiates an `AsValidator` per renamed parameter
— a marker whose `validate_param!` is empty and which nothing reads.

Accept it as a keyword instead, defaulting to whatever an enclosing `with`
supplied so the declaration keeps winning over the group. The options Hash
carries only what the validation pipeline is meant to read.

`Grape::Validations::Validators::AsValidator` is left in place; it is a
public constant and removing it is a separate decision.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1239 of 1330 branches covered (93.16%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

3883 of 3951 relevant lines covered (98.28%)

27123.0 hits per line