OpenCHAMI / ochami / 33217752277
12%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 195
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 12.061% (+0.5%) from 11.582%
33217752277

push

github

web-flow 
refactor(config): use more of koanf's builtins instead of custom YAML unmarshaling (#148)

* Compiles (failing tests)

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* partially failing tests

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Fix tests

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Fix timeout flag default

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Add forgotten error handling

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Revert testing change

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* remove vestigial commented function cal

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Fix --ignore-config

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Appease the linter (and fix a typo I noticed along the way)

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Fix cluster delete subcommand

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Fix file-specific config loading not setting the global config variables

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Fix unhandled assertion in LoadGlobalConfigMerged

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Fix hard coded default timeout arg option

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* reenable strict merge

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Clarify lack of omitempty

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Add doc comments

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Move GlobalKoanf assignment later down for semantic clarity

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Remove vestigial debugging config load

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Clarify cluster merging behavior comment

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Fix error handling typo in cluster unmerging

Signed-off-by: Ethan Clark <ethanclark067@gmail.com>

* Add check for empty name

Signed-off-by: Ethan Clark... (continued)

310 of 493 new or added lines in 14 files covered. (62.88%)

14 existing lines in 5 files now uncovered.

1906 of 15803 relevant lines covered (12.06%)

0.86 hits per line

Uncovered Changes

Lines Coverage ∆ File
68
74.38
 10.79% internal/config/config.go
34
0.0
 0.0% cmd/config/cluster/cluster-delete.go
21
12.72
 -0.45% internal/cli/cli.go
17
75.71
 internal/config/validate.go
16
0.0
 0.0% cmd/config/cluster/cluster-show.go
7
0.0
 0.0% cmd/config/show.go
5
0.0
 0.0% cmd/cloud_init/group/render.go
4
0.0
 0.0% cmd/bss/boot/image/set.go
4
90.63
 -5.99% internal/config/merge.go
3
0.0
 0.0% pkg/client/rcs/rcs.go
2
61.11
 -1.75% internal/log/log.go
1
0.0
 0.0% cmd/boot/boot.go
1
0.0
 0.0% cmd/metadata/metadata.go

Coverage Regressions

Lines Coverage ∆ File
10
74.38
 10.79% internal/config/config.go
1
0.0
 0.0% cmd/config/cluster/cluster-delete.go
1
0.0
 0.0% cmd/config/cluster/cluster-show.go
1
0.0
 0.0% cmd/config/show.go
1
12.72
 -0.45% internal/cli/cli.go
Jobs
ID Job ID Ran Files Coverage
1 33217752277.1 195
12.06
 GitHub Action Run
Source Files on build 33217752277