OpenCHAMI / ochami

93%

LAST BUILD ON BRANCH main

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• chore/deps/go-1.27
• chore/go-1.27.3
• ci/coveralls
• ci/fix-badges
• ci/fix-codeql
• ci/gh-actions-commit-shas
• ci/goreleaser/dockers-v2
• ci/renovate-config-updates
• ci/standardize-check-names
• dependabot/go_modules/github.com/go-jose/go-jose/v4-4.1.6
• docs-smd-iface-man
• docs/add-changelog
• fix-metadata-delete-confirm
• fix-metadata-uri-help
• fix/blank-ids
• fix/bool-flags
• fix/cacert-insecure-mutual-exclusion
• fix/ctrl-c-context
• fix/data-flag-override
• fix/deps-jwx-v4
• fix/doc-comment-typos
• fix/json-merge-patch-flags
• fix/log-format-json
• fix/metadata-patch-flag-panic
• fix/rcs-console-close-frame-race
• fix/smd-delete-all-args
• fix/smd-iface-man
• log-unmarshal-fix
• main
• renovate/github-actions-(minorpatch)
• renovate/github.com-lestrrat-go-jwx-v3-4.x
• renovate/go-github.com-go-jose-go-jose-v4-vulnerability
• renovate/go-modules-(minorpatch)
• renovate/golang-1.x
• renovate/renovate-validator
• smd-add-single-cacert
• stack/coverage/01-exit-code-contract
• stack/coverage/02-client-contract-tests
• stack/coverage/03-command-e2e-and-interactive
• stack/coverage/04-public-config
• stack/coverage/05-injected-boundaries
• stack/coverage/06-coverage-regressions
• stack/coverage/07-command-and-client-cleanup
• stack/coverage/08-output-and-error-injection
• stack/coverage/09-http-client-foundations
• stack/coverage/10-configfile-and-rcs-hardening
• stack/coverage/11-typed-batches-and-context
• stack/coverage/12-local-command-options
• stack/coverage/13-runtime-core-and-command-migration
• stack/coverage/14-test-parallelization-and-race-detection
• stack/coverage/15-final-coverage-closure
• stack/coverage/16-convention-checks
• test/organize
• test/refactor-cacert-tests
• test/reorganize

Build # 42888570279

Build Type

push

github

Committed by web-flow

Commit Message

test: enforce test file stems and remove duplicate error tests (#243)

* test: ignore non-platform tags in subject grouping

The test file check groups a subject's tests by platform, but platform()
used the whole //go:build expression as the group. A file tagged "linux
&& integration" got its own group, apart from *_linux_test.go, so a
non-platform tag could split a subject's tests without a violation. The
same goes for equivalent constraints written differently, such as
"amd64 && linux" and *_linux_amd64_test.go.

Compare the GOOS/GOARCH pairs a file can build for rather than the text
of its constraints. A file name and a constraint that select the same
platforms now group together, whatever their order. Tags that don't name
a platform don't make a file platform-specific: each setting of them is
tried, with one value per tag across the file, so "(linux || integration)
&& !integration" still counts as Linux. This replaces namesPlatform.

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>

* test: keep subject bucket files on one stem

CONTRIBUTING.md names a subject's files <subject>_test.go,
<subject>_errors_test.go, and <subject>_boundary_test.go, but nothing
checks that those files share a stem. TestLoad, TestValidateConfig,
TestInitLogging, and TestRuntimeHandlePayload each had a bucket in a file
named after something else, so a reader who opens the plain test file
wouldn't find the rest next to it.

Move those tests to files that match, without changing them. Add a check
that flags a subject's bucket files with different stems, and describe
the rule in CONTRIBUTING.md. The check compares only files for the same
platforms, using platform(), and leaves out the error tables across cmd
families in commands_errors_test.go, whose plain tests are in a file
named after the behavior.

Also rename TestBSSHistoryGet_* to TestBSSHistory_*, since "bss history"
is a leaf command and there is no "bss history get".

Signed-off-by: Devon Ba... (continued)

Coverage Stats

13626 of 14624 relevant lines covered (93.18%)

754.83 hits per line