Rotorsoft / act-root / 33106512168

100%

push

github

fix(act): normalize the lane name on both sides of the agreement guard (#1586)

Two reactions to the same target must declare the same lane, and the
build-time guard stored the raw declaration to compare later ones against.
An omitted lane and an explicit "default" are the same lane, but raw they
are `undefined` and `"default"` — so a legal, fully type-checked config
failed to build. The comparison read `?? undefined` on both operands,
which normalizes nothing; the message read `?? "default"`, which is why
the diagnostic named the same lane twice and gave the operator nothing to
act on.

Both sides now compare `lane_name`, the normalized value the classifier
already computes three lines earlier, and the message drops its own
normalization since both operands arrive normalized.

Genuine disagreements are untouched: "slow" against an omitted lane still
throws, now naming "slow" vs "default" correctly.

Closes #1583

Co-authored-by: rotorsoft <rotorsoft@outlook.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

4294 of 4294 branches covered (100.0%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

9275 of 9275 relevant lines covered (100.0%)

1168.37 hits per line