Tatsh / dade / 33104986869

100%

push

github

rbplus: stop the chart fit looping on a phone, and ship source maps

The fit measured the window as `window.innerHeight` and re-fitted whenever it
changed. On Android Chrome the address bar retracts as the page grows and
extends as it shrinks, so each fit moved the height that drove it and the two
never settled: React aborted the render with "Maximum update depth exceeded"
(minified error #185). Measure the small viewport (`100svh`) instead, which the
page cannot move, so the chart fits whether the bar is shown or hidden and the
fit has nothing to feed back on. As a backstop, the correction now counts its
tries and stops after a bounded number rather than looping on any window that
will not steady, and it is forgotten only when the seconds that fit actually
change, not on sub-second wobble.

Emit a full source map from the production build as well, so an error in the
shipped script can be read against the original TypeScript. The build hides
nothing. The whole generated bundle, source maps included, is kept out of
spell-checking.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

4284 of 4284 branches covered (100.0%)

Branch coverage included in aggregate %.

16940 of 16940 relevant lines covered (100.0%)

5.0 hits per line