coreui / coreui-pro / 32919094164

93%

main: 94%

push

github

fix(DateRangePicker): give each half of the range its own name (#913)

* docs(pickers): document the option that names the control

The four pickers mount on a `<div>`, so `<label for>` has nothing to point at
and the accessible name has to come from the component. `ariaLabel` already
does that — it reaches the `role="group"` container through the shell's config
forwarding, programmatically and through `data-coreui-aria-label` alike — but it
was in none of the four Options tables. The pages documented
`ariaCleanerLabel` and `ariaToggleLabel`, the names of the two buttons, while
the name of the field itself was reachable only by knowing it existed.

Defaults were read off the rendered element rather than the source: `Date
input` for the date and range pickers, `Date and time input`, `Time input`.

The range picker's row carries a warning the others do not need: it applies the
same name to the start and the end field, so both halves announce alike. That
is a defect in the component rather than in this table, and it is recorded
separately.

* fix(DateRangePicker): give each half of the range its own name

Both fields of the range are the same primitive, and both received the same
accessible name: `Date input` twice by default, and whatever `ariaLabel` was
set to twice otherwise. Someone moving from the start date to the end date
heard the identical name and had nothing to tell them which end they were on.

`ariaLabels` names them in order, defaulting to `Start date` and `End date`, so
the control is correct before anyone configures it. A shorter array leaves the
remaining field on its default rather than dropping its name.

The array follows the shape Range Slider already uses for the same problem — a
control whose parts each need a name — rather than a pair of single-purpose
options. It also stays translatable: each entry is a whole string, where a
shared name with a suffix glued on survives English and little else.

Measured on the built bundle: defaul... (continued)

4619 of 5202 branches covered (88.79%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

8831 of 9244 relevant lines covered (95.53%)

392.98 hits per line