coreui / coreui-pro / 32673547814

95%

main: 94%

push

github

fix(Navbar): declare the values it draws with, and let a theme win (#865)

* fix(Navbar): declare the values it draws with, and let a theme win

Four things the v6-dev comparison turned up, none of them visible until you try
to change something.

`.navbar-text` had its padding compiled into the rule. That padding exists to line
the text up with the nav links, and the value it pairs with — `--cui-nav-link-padding-y`
— is declared on `.navbar-nav`, which is `.navbar-text`'s sibling. So the pair
could not be kept in step from anywhere: not from the navbar, not from the nav,
not by the user. `--cui-navbar-text-padding-y` is declared on `.navbar`, which
both of them can see.

The hamburger glyph was a hard-coded `1.5em` in a component whose every other
measurement is a token. It reads `--cui-navbar-toggler-icon-size` now.

`--cui-navbar-brand-color`, `-brand-hover-color` and `-active-color` carried the
`--cui-theme-*` slot inside their own defaults rather than on the property that
reads them. That inverts the precedence: setting the token inside a themed navbar
dropped the theme, where every other component lets the theme win. Measured in
Chromium — a `.theme-primary` navbar with `--cui-navbar-brand-color: red` rendered
red before and renders the theme color now, and that is the only computed change
in the whole component.

`$navbar-dark-toggler-border-color` was declared twice on one line.

* feat(Navbar)!: minimum height, link gap, brand weight, translucent, drawer

Takes the parts of upstream's navbar that do not depend on their markup changes,
and fixes the one real gap the comparison exposed.

`.navbar-expand-*` flattens a `.drawer` now, not only an `.offcanvas`. The reset
that turns a collapsed panel back into an inline nav named `.offcanvas` alone, so
a drawer used as the collapsed panel stayed a fixed side panel over the page at
every width — measured at 400x868 beside the offcanvas's 1176x24 in the same
expanded navbar. Both flatten. The pairing m... (continued)

4532 of 5097 branches covered (88.92%)

Branch coverage included in aggregate %.

8653 of 9054 relevant lines covered (95.57%)

400.08 hits per line