coreui / coreui-pro / 32661491766

96%

main: 94%

push

github

refactor(ListGroup): color the whole item from the theme tokens (#862)

The contextual variants declared ten `--cui-list-group-*` overrides on top of
`theme-tokens()`. Eight of them never applied: the properties they targeted
already read the matching `--cui-theme-*` slot, so the fallback those overrides
were written for never resolved. `.list-group-item-{color}` is the theme mixin
alone now, and it renders identically to `.theme-{color}` on the same element.

`.list-group-item-action` kept its unthemed colors inside a themed item: grey
link text on a tinted background, near-black on hover, next to plain items that
were already colored. It reads `--cui-theme-fg` and `--cui-theme-fg-emphasis`
now, so an actionable row matches the rows beside it.

The themed hover background moves from `--cui-theme-border` to
`--cui-theme-bg-muted`. It resolved to the same tone as the border, so hovering
a row erased the line separating it from its neighbours. Pressed keeps the
border tone, which puts the two states back on separate steps.

Item borders switch to `border-block-start-width` / `border-block-end-width`,
matching the inline-axis borders the horizontal variant already sets.

4532 of 5097 branches covered (88.92%)

Branch coverage included in aggregate %.

8653 of 9054 relevant lines covered (95.57%)

400.09 hits per line