coreui / coreui-pro / 32660302067

96%

main: 94%

push

github

refactor(scss): declare and generate every size from a map (#860)

* refactor(scss): declare every size map through defaults()

A bare `!default` list or map can only be replaced wholesale: adding `xl` to the
buttons meant restating `("xs", "sm", "lg", "xl")` and freezing our list into
the override, and changing one avatar size meant restating the other three with
values nobody wanted to touch. Through `defaults()` an override merges, and a
key set to `null` removes a size.

Covers `$button-sizes`, `$input-group-sizes`, `$switch-sizes`,
`$form-switch-sizes` and `$avatar-sizes`; `$dialog-sizes` and
`$pagination-sizes` already had it.

`defaults()` turns a list into a map keyed on its entries, so the loops
destructure the pair (`@each $size, $_ in`) and the deprecated-switch check
asks `map.has-key()` instead of `list.index()`.

Each map moves out of its `*-variables` block into its own documented one, and
the docs pages cite it — inside the variables block it would have disappeared
from them.

Compiled `coreui.css` is byte-identical to `v6-dev`, compared by building both
from source.

* refactor(scss): generate the control sizes from a map

`.form-control-sm` and `.form-control-lg` were two eighteen-line blocks
differing only in the word `sm` or `lg`, and the control group and the OTP input
repeated the same shape again. Each family now loops over a size map, so a size
is defined in one place instead of copied and edited.

`$form-control-sizes` is a plain list — every value it needs comes from
`--cui-btn-input-<size>-*`. `$form-control-group-sizes` and `$form-otp-sizes`
are maps, because those two carry values of their own (icon and action sizes,
control width and padding); the existing per-size Sass variables feed the maps,
so every knob that was there still is.

Compiled `coreui.css` is byte-identical, compared by building both sides from
source.

* refactor(scss): generate the badge, rating and chip input sizes from a map

The last three components ... (continued)

4532 of 5097 branches covered (88.92%)

Branch coverage included in aggregate %.

8653 of 9054 relevant lines covered (95.57%)

400.01 hits per line