coreui / coreui-pro / 32655398929

96%

main: 94%

push

github

fix(Alert): drive the exit from .hiding instead of the .fade class (#857)

An alert is already on the page when the JS reaches it, so removing `.show`
could not mark the exit — an alert without `.show` had nothing to remove, and
one without `.fade` was deleted with no transition at all. The alert carries its
own transition and `--cui-alert-transition-property` / `-duration` / `-timing`
now, and `close()` marks it with `.hiding` for the length of that transition
before removing the element. `.alert-instant` opts out.

`.fade` and `.show` keep their meaning for the other direction: an alert
inserted at runtime while carrying them still fades in, through the
`@starting-style` rule that was already here. Only the exit changes hands.

`.hiding` is what the dialog, drawer and offcanvas already use to mark a
running exit.

4532 of 5097 branches covered (88.92%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

8653 of 9054 relevant lines covered (95.57%)

400.0 hits per line