32618910791
75%

Ran 23 Aug 2026 05:57AM UTC

Jobs 1

Files 68

Run time 1min

Badge

Embed ▾

Committed 21 Aug 2026 01:50PM UTC coverage: 72.777% (+0.2%) from 72.623%

Build # 32618910791

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Rejected consumer create destroys existing consumer state (#8491)

This PR fixes a number of issues relating to errors on consumer create:
- `setConsumer` no longer overwrites an existing consumer and
`removeConsumer` only unregisters when the entry is the same instance
that is passed, so a stale consumer with the same name can't evict the
live consumer from `mset.consumers`, `cList` and `csl`.
- The name-exists check now runs before
`mset.store.ConsumerStore(o.name, ...)`, which opened the existing
consumer's on-disk directory and then deleted it when the rejected
create tore itself down.
- Error paths release the temporary consumer with `o.stop()` instead of
`o.deleteWithoutAdvisory()`, which on the early name checks could
`os.RemoveAll` an unrelated stream named `obs` (unlikely but fixed
anyhow).
- The `ackMsgs`/`nextMsgReqs` ipQueues are created after the name-exists
check, since they key `s.ipQueues` by consumer name and the rejected
create overwrote and then unregistered the live consumer's entries.
- `mset.numFilter` is removed, as it was maintained in three places,
never read, and miscounted consumers using `FilterSubjects`.

In practice the name-exists paths above only apply to single/standalone
servers, since clustered paths perform this check elsewhere and would
prevent it.

Coverage Stats

62310 of 85618 relevant lines covered (72.78%)

349229.74 hits per line

Coverage Regressions

Lines	Coverage	∆	File
40	78.7	-0.41%	src/github.com/nats-io/nats-server/server/raft.go
17	82.7	0.43%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
14	65.12	1.37%	src/github.com/nats-io/nats-server/server/jetstream_api.go
13	84.45	-0.18%	src/github.com/nats-io/nats-server/server/consumer.go
9	74.5	-0.06%	src/github.com/nats-io/nats-server/server/stream.go
8	76.8	0.58%	src/github.com/nats-io/nats-server/server/filestore.go
7	60.56	0.19%	src/github.com/nats-io/nats-server/server/opts.go
5	87.03	-0.07%	src/github.com/nats-io/nats-server/server/client.go
5	85.2	0.04%	src/github.com/nats-io/nats-server/server/server.go
4	93.09	-0.05%	src/github.com/nats-io/nats-server/server/gateway.go
3	83.49	0.0%	src/github.com/nats-io/nats-server/server/events.go
3	40.39	0.21%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
3	81.19	-0.14%	src/github.com/nats-io/nats-server/server/route.go
2	77.69	-0.06%	src/github.com/nats-io/nats-server/server/accounts.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	32618910791.1	23 Aug 2026 05:57AM UTC	68	72.78	GitHub Action Run

nats-io / nats-server / 32618910791
75%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 32618910791

nats-io / nats-server / 32618910791 75%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 32618910791

nats-io / nats-server / 32618910791
75%

README BADGES
x