32552790502
75%

Ran 22 Aug 2026 05:56AM UTC

Jobs 1

Files 68

Run time 1min

Badge

Embed ▾

Committed 21 Aug 2026 01:50PM UTC coverage: 72.623% (+2.5%) from 70.16%

Build # 32552790502

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] Rejected consumer create destroys existing consumer state (#8491)

This PR fixes a number of issues relating to errors on consumer create:
- `setConsumer` no longer overwrites an existing consumer and
`removeConsumer` only unregisters when the entry is the same instance
that is passed, so a stale consumer with the same name can't evict the
live consumer from `mset.consumers`, `cList` and `csl`.
- The name-exists check now runs before
`mset.store.ConsumerStore(o.name, ...)`, which opened the existing
consumer's on-disk directory and then deleted it when the rejected
create tore itself down.
- Error paths release the temporary consumer with `o.stop()` instead of
`o.deleteWithoutAdvisory()`, which on the early name checks could
`os.RemoveAll` an unrelated stream named `obs` (unlikely but fixed
anyhow).
- The `ackMsgs`/`nextMsgReqs` ipQueues are created after the name-exists
check, since they key `s.ipQueues` by consumer name and the rejected
create overwrote and then unregistered the live consumer's entries.
- `mset.numFilter` is removed, as it was maintained in three places,
never read, and miscounted consumers using `FilterSubjects`.

In practice the name-exists paths above only apply to single/standalone
servers, since clustered paths perform this check elsewhere and would
prevent it.

Coverage Stats

62178 of 85618 relevant lines covered (72.62%)

343371.65 hits per line

Coverage Regressions

Lines	Coverage	∆	File
787	74.57	1.4%	src/github.com/nats-io/nats-server/server/stream.go
380	84.63	14.71%	src/github.com/nats-io/nats-server/server/consumer.go
87	79.11	0.71%	src/github.com/nats-io/nats-server/server/raft.go
84	82.28	1.43%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
40	76.23	0.71%	src/github.com/nats-io/nats-server/server/filestore.go
18	60.36	0.5%	src/github.com/nats-io/nats-server/server/opts.go
13	40.18	9.61%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
8	87.11	0.59%	src/github.com/nats-io/nats-server/server/client.go
8	63.75	7.22%	src/github.com/nats-io/nats-server/server/jetstream_api.go
7	83.49	-0.36%	src/github.com/nats-io/nats-server/server/events.go
6	69.23	2.94%	src/github.com/nats-io/nats-server/server/monitor.go
4	85.16	1.17%	src/github.com/nats-io/nats-server/server/server.go
3	74.18	2.6%	src/github.com/nats-io/nats-server/server/leafnode.go
2	96.88	0.0%	src/github.com/nats-io/nats-server/server/jetstream_versioning.go
2	81.43	-0.27%	src/github.com/nats-io/nats-server/server/parser.go
1	93.14	0.82%	src/github.com/nats-io/nats-server/server/gateway.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	32552790502.1	22 Aug 2026 05:56AM UTC	68	72.62	GitHub Action Run

nats-io / nats-server / 32552790502
75%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 32552790502

nats-io / nats-server / 32552790502 75%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 32552790502

nats-io / nats-server / 32552790502
75%

README BADGES
x