ruby-grape / grape / 32582889873

97%

push

github

Render a redirect message as the plain text it claims to be (#2845)

#redirect announces its message as text/plain and has done since it was
introduced in 2015 ("Redirect as plain text with optional message override"),
but it only set the header. The body was still handed to the API's own
formatter, so on a JSON API the sentence came back JSON-encoded:

    format :json
    get('/r') { redirect '/there' }

    Content-Type: text/plain
    "This resource has been moved temporarily to /there."

quotes included -- neither valid plain text nor something a client reading the
content type would expect. The existing specs missed it because they run on
the default :txt format, where the formatter is a no-op.

Set api.format alongside the header, the same lever an endpoint already has
via #api_format, so the message is rendered by the txt formatter whatever the
API declares. It is per-request env, so other routes on the same API are
untouched.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1225 of 1314 branches covered (93.23%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

3843 of 3911 relevant lines covered (98.26%)

27211.64 hits per line