PHPOffice / PHPPresentation / 32552921295

92%

push

github

Tell a shape that asked for no fill from one that named none (#915)

`loadStyleFill()` returned `null` in two different cases: a `p:spPr` that names
no fill at all, and one that carries `a:noFill`. The second is not an absence --
it is a shape saying it wants to stay transparent, which is what PowerPoint
writes whenever you clear a fill -- so it now comes back as a `Fill` of type
`FILL_NONE`.

That also removes one of the two ways a real deck kills a format conversion:
`setFill(null)` stored the null, `getFill()` handed it on, and the
ODPresentation Writer dereferenced it (`Content.php:983`). Reading a PowerPoint
file and saving it as ODP no longer dies on any shape whose fill was cleared.

The remaining `null` -- a shape with no fill element whatsoever -- is left as it
is: that one is about `?Fill` in the signatures, and it is a larger question.

5 of 5 new or added lines in 1 file covered. (100.0%)

10221 of 11091 relevant lines covered (92.16%)

45.07 hits per line