PHPOffice / PHPPresentation / 32618245238

92%

push

github

Leave the test suite with nothing to report, and keep it that way (#920)

Three things the suite has been printing under every run, none of them noise.

`getimagesize()` answers `false` for a file it cannot measure -- an SVG, a
video -- and both callers destructured that answer straight into a width and a
height: `Cannot use bool as array`, three tests, twice each. The size such a
file ends up with is the size it already had, which is nothing, so the fix is
to assign only when there is something to assign.

`HashTable::add()` looked the source up by `getHashIndex()`, which is null
until the table has given the object one. `isset($array[null])` reads the key
as an empty string, so the lookup was correct and merely deprecated -- 184
tests said so on every run. It now asks whether there is an index first.

The five mock objects nobody configured an expectation on are stubs, which is
what PHPUnit says in the notice, so they are built with `createStub()`.

The gates that hold this are split in two, because PHPUnit splits them.
`phpunit.xml.dist` takes the three the declared 9.3 schema knows --
`failOnWarning`, `failOnRisky`, `failOnEmptyTestSuite` -- and the rest exist
only on the command line, so the workflow passes `--fail-on-deprecation`,
`--fail-on-notice` and `--fail-on-phpunit-deprecation` on one leg. Without
them PHPUnit ends a run that had something to report with "OK, but there were
issues" and exit code 0, and CI stays green while the report grows back.

That leg is 8.5: the newest PHP is where a deprecation appears first. It also
takes the coverage run over from 8.3, so that exactly one leg of the matrix is
out of the ordinary rather than two.

7 of 7 new or added lines in 3 files covered. (100.0%)

10225 of 11095 relevant lines covered (92.16%)

45.06 hits per line