PHPOffice / PHPPresentation / 32465444678

93%

push

github

ODPresentation Writer : Keep the background of a master slide (#912)

* A master slide is no longer born with a white background

`SlideMaster::__construct()` set a white `Background\Color` on every master it created, and the
PowerPoint2007 Writer turned it into `<p:bg>`. A converter paints that fill as a full-page path of
its own, outside any marked content, which PDF/UA 7.1 refuses -- one failed check per page, on a
deck that never asked for the fill and draws its own backgrounds over it.

Nothing is lost by leaving it out. The colour map takes the background of a master to `lt1`, and
`lt1` is white, so the page renders exactly as it did: converted to PDF before and after, no pixel
differs in colour, and the only difference is the alpha of the outermost row and column -- the
antialiased edge of a fill that is no longer there.

A master that is given a background still writes one. This only stops the library from inventing
one nobody asked for.

* ODPresentation Writer : Keep the background of a master slide

Every place the Writer read a background took it from a slide, so a background set on the master was
dropped on save -- and PowerPoint is where a deck usually keeps it. `Styles.php` did write a
`style:master-page` with a `draw:style-name`, but the style it named, `sPres0`, was a hardcoded
`style:family="presentation"` carrying a `draw:fill-color` in graphic-properties: the wrong family,
the wrong property, and no `draw:fill` to switch it on. It painted nothing.

That style is now what its name says it is: a drawing-page style built from the background of the
master, a colour or an image. It has to live among the automatic styles -- LibreOffice reads it
from nowhere else, and leaves it undrawn in `office:styles`, which is where it used to sit.

An image also has to reach the package and the manifest, so both now look at the master as well as
at the slides.

34 of 35 new or added lines in 4 files covered. (97.14%)

10216 of 11086 relevant lines covered (92.15%)

44.9 hits per line